Skip to content

Extended testing fixes, simplified np.array reading, citation file#30

Open
hgp297 wants to merge 20 commits into
OpenPBEE:mainfrom
hgp297:recursive_array_conversion
Open

Extended testing fixes, simplified np.array reading, citation file#30
hgp297 wants to merge 20 commits into
OpenPBEE:mainfrom
hgp297:recursive_array_conversion

Conversation

@hgp297

@hgp297 hgp297 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Post Jun 5th meeting updates

  • Unified testing metrics to agreed values (see tests/README.md)
  • System-level metrics still gated
  • Added reference fixture for RCSW_1story and haseltonRCMF_12story
  • driver.py now reads output np.array recursively to convert to python (as opposed to 5-level nested loop)
  • Citation file added (please review)
  • Quality-of-life for plotting to enhance visibility on overlapping line plots

Results

Passed 17/18 integration tests. Failed test had Metric 1 = 2.1 > 2.0 and Metric 2 < 4.0.

hgp297 and others added 20 commits April 29, 2026 14:42
- explicitly checking comp_population headers for 'story' and 'dir' rather than excluding by index
- High level metrics in compare_runs.evaluate_tolerances now considers path if either relative difference < 4% OR absolute difference < 2 days
- test_integration.py ungates ASSERT_POINTWISE
- renamed metrics writeup to README.md so that it displays in github in the test folder
- Added a section in README.md to describe what is considered passing in Mat-Py testing
- added utility file with functions to batch run folder in testing directory
These values correspond to those set at the Jan 22 2026 standup meeting

- MAE lowered to 1%
- P95 lowered to 2%
Zaidi et al. (2026) is the citation for the package, but the preferred citation is Cook et al. (2022).
- driver.py now has recursive np conversion to traverse nested arrays
without pre-specifying levels.
- outputting new damage_consequences as consequences.json (contains red
  tag info)
switched nested functionality array-to-list conversion to use the
recursive method
This reverts commit a51a500.
System-level point-wise thresholds reverted to P95 <=4% and MAE <= 2%.
@hgp297
hgp297 requested review from dustin-cook and zsarnoczay June 5, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant